Pārlūkot izejas kodu

Merge pull request #407 from AtkinsSJ/clean-suggested-apps

fix: Remove null or duplicate app entries from suggest_app_for_fsentry()
Eric Dubé 1 gadu atpakaļ
vecāks
revīzija
80b763c47c
1 mainītis faili ar 9 papildinājumiem un 1 dzēšanām
  1. 9 1
      packages/backend/src/helpers.js

+ 9 - 1
packages/backend/src/helpers.js

@@ -1770,7 +1770,15 @@ async function suggest_app_for_fsentry(fsentry, options){
     monitor.end();
 
     // return list
-    return suggested_apps;
+    return suggested_apps.filter((suggested_app, pos, self) => {
+        // Remove any null values caused by calling `get_app()` for apps that don't exist.
+        // This happens on self-host because we don't include `code`, among others.
+        if (!suggested_app)
+            return false;
+
+        // Remove any duplicate entries
+        return self.indexOf(suggested_app) === pos;
+    });
 }
 
 function build_item_object(item){