Browse Source

fix: fix 500 when check-app has bad url

KernelDeimos 9 months ago
parent
commit
9a622004ea
2 changed files with 7 additions and 0 deletions
  1. 4 0
      src/backend/src/api/APIError.js
  2. 3 0
      src/backend/src/services/auth/AuthService.js

+ 4 - 0
src/backend/src/api/APIError.js

@@ -482,6 +482,10 @@ module.exports = class APIError {
             status: 422,
             message: 'This share can not be applied to this user.',
         },
+        'no_origin_for_app': {
+            status: 400,
+            message: 'Puter apps must have a valid URL.'
+        },
 
         // Chat
         // TODO: specifying these errors here might be a violation

+ 3 - 0
src/backend/src/services/auth/AuthService.js

@@ -442,6 +442,9 @@ class AuthService extends BaseService {
 
     async app_uid_from_origin (origin) {
         origin = this._origin_from_url(origin);
+        if ( origin === null ) {
+            throw APIError.create('no_origin_for_app');
+        }
         return await this._app_uid_from_origin(origin);
     }