Преглед на файлове

fix(phoenix): Gracefully handle completing a non-existent path

filesystem.readdir() can throw, which previously would crash Phoenix and
leave the terminal unresponsive. This change makes it return no results
instead.
Sam Atkins преди 11 месеца
родител
ревизия
d76e7130cb
променени са 1 файла, в които са добавени 9 реда и са изтрити 4 реда
  1. 9 4
      packages/phoenix/src/puter-shell/completers/FileCompleter.js

+ 9 - 4
packages/phoenix/src/puter-shell/completers/FileCompleter.js

@@ -33,12 +33,17 @@ export class FileCompleter {
 
         const completions = [];
 
-        const result = await filesystem.readdir(dir);
-        if ( result === undefined ) {
-            return [];
+        let dir_entries;
+        try {
+            dir_entries = await filesystem.readdir(dir);
+        } catch (e) {
+            // Ignored
         }
 
-        for ( const item of result ) {
+        if ( dir_entries === undefined )
+            return [];
+
+        for ( const item of dir_entries ) {
             if ( item.name.startsWith(base) ) {
                 completions.push(item.name.slice(base.length));
             }