Просмотр исходного кода

fix(phoenix): Gracefully handle completing a non-existent path

filesystem.readdir() can throw, which previously would crash Phoenix and
leave the terminal unresponsive. This change makes it return no results
instead.
Sam Atkins 11 месяцев назад
Родитель
Сommit
d76e7130cb
1 измененных файлов с 9 добавлено и 4 удалено
  1. 9 4
      packages/phoenix/src/puter-shell/completers/FileCompleter.js

+ 9 - 4
packages/phoenix/src/puter-shell/completers/FileCompleter.js

@@ -33,12 +33,17 @@ export class FileCompleter {
 
         const completions = [];
 
-        const result = await filesystem.readdir(dir);
-        if ( result === undefined ) {
-            return [];
+        let dir_entries;
+        try {
+            dir_entries = await filesystem.readdir(dir);
+        } catch (e) {
+            // Ignored
         }
 
-        for ( const item of result ) {
+        if ( dir_entries === undefined )
+            return [];
+
+        for ( const item of dir_entries ) {
             if ( item.name.startsWith(base) ) {
                 completions.push(item.name.slice(base.length));
             }