code review

nicegui/elements/icon.py

@@ -1,7 +1,7 @@
 from typing import Optional
 
-from .mixins.name_element import NameElement
 from .mixins.color_elements import TextColorElement
+from .mixins.name_element import NameElement
 
 
 class Icon(NameElement, TextColorElement):
@@ -23,7 +23,6 @@ class Icon(NameElement, TextColorElement):
         :param color: icon color (either a Quasar, Tailwind, or CSS color or `None`, default: `None`)
         """
         super().__init__(tag='q-icon', name=name, text_color=color)
-        self._props['name'] = name
 
         if size:
             self._props['size'] = size

nicegui/elements/mixins/name_element.py

@@ -11,8 +11,8 @@ class NameElement(Element):
 
     def __init__(self, *, name: str, **kwargs: Any) -> None:
         super().__init__(**kwargs)
+        self.name = name
         self._props['name'] = name
-        self._name_to_model_name(name)
 
     def bind_name_to(self,
                      target_object: Any,
@@ -69,16 +69,12 @@ class NameElement(Element):
 
         :param name: The new name.
         """
-        self._props['name'] = name
-        self.update()
+        self.name = name
 
     def on_name_change(self, name: str) -> None:
         """Called when the name of this element changes.
 
         :param name: The new name.
         """
-        self._name_to_model_name(name)
-        self.update()
-
-    def _name_to_model_name(self, name: str) -> None:
         self._props['name'] = name
+        self.update()