code review

nicegui/helpers.py

@@ -10,7 +10,7 @@ import time
 import webbrowser
 from contextlib import nullcontext
 from pathlib import Path
-from typing import TYPE_CHECKING, Any, Awaitable, Callable, Generator, List, Optional, Tuple, Union
+from typing import TYPE_CHECKING, Any, Awaitable, Callable, Generator, Optional, Tuple, Union
 
 from fastapi import Request
 from fastapi.responses import StreamingResponse

nicegui/nicegui.py

@@ -1,4 +1,3 @@
-from . import welcome
 import asyncio
 import time
 import urllib.parse
@@ -14,7 +13,7 @@ from fastapi_socketio import SocketManager
 from nicegui import json
 from nicegui.json import NiceGUIJSONResponse
 
-from . import __version__, background_tasks, binding, favicon, globals, outbox
+from . import __version__, background_tasks, binding, favicon, globals, outbox, welcome
 from .app import App
 from .client import Client
 from .dependencies import js_components, libraries

nicegui/welcome.py

@@ -1,6 +1,7 @@
+import os
 from typing import List
+
 from .globals import optional_features
-import os
 
 try:
     import netifaces
@@ -21,7 +22,7 @@ def get_all_ips() -> List[str]:
     return ips
 
 
-def print_message():
+def print_message() -> None:
     host = os.environ['NICEGUI_HOST']
     port = os.environ['NICEGUI_PORT']
     ips = set(get_all_ips() if host == '0.0.0.0' else [])