code review

nicegui/functions/download.py

@@ -1,7 +1,7 @@
 from pathlib import Path
 from typing import Optional, Union
 
-from .. import globals
+from .. import globals, helpers
 
 
 def download(src: Union[str, Path], filename: Optional[str] = None) -> None:
@@ -9,9 +9,9 @@ def download(src: Union[str, Path], filename: Optional[str] = None) -> None:
 
     Function to trigger the download of a file.
 
-    :param src: target URL or local filename which should be downloaded
+    :param src: target URL or local path of the file which should be downloaded
     :param filename: name of the file to download (default: name of the file on the server)
     """
-    if Path(src).is_file():
+    if helpers.is_file(src):
         src = globals.app.add_static_file(local_file=src)
     globals.get_client().download(src, filename)

tests/conftest.py

@@ -1,6 +1,7 @@
 import importlib
 import os
 import shutil
+from pathlib import Path
 from typing import Dict, Generator
 
 import icecream
@@ -11,10 +12,11 @@ from webdriver_manager.chrome import ChromeDriverManager
 
 from nicegui import Client, globals
 from nicegui.page import page
-from .test_helpers import DOWNLOAD_DIR
 
 from .screen import Screen
 
+DOWNLOAD_DIR = Path(__file__).parent / 'download'
+
 icecream.install()
 
 

tests/test_download.py

@@ -1,12 +1,13 @@
 from pathlib import Path
+
 from fastapi.responses import PlainTextResponse
 
 from nicegui import app, ui
 
+from .conftest import DOWNLOAD_DIR
 from .screen import Screen
-from .test_helpers import TEST_DIR, DOWNLOAD_DIR
 
-IMAGE_FILE = Path(TEST_DIR).parent / 'examples' / 'slideshow' / 'slides' / 'slide1.jpg'
+IMAGE_FILE = Path(__file__).parent.parent / 'examples' / 'slideshow' / 'slides' / 'slide1.jpg'
 
 
 def test_download_text_file(screen: Screen):

tests/test_helpers.py

@@ -7,7 +7,6 @@ from pathlib import Path
 from nicegui import helpers
 
 TEST_DIR = Path(__file__).parent
-DOWNLOAD_DIR = TEST_DIR / 'download'
 
 
 def test_is_port_open():