Browse Source

#713 remove no-parent-event prop for ui.menu

Falko Schindler 2 years ago
parent
commit
84aa31d50c
2 changed files with 1 additions and 3 deletions
  1. 1 2
      main.py
  2. 0 1
      nicegui/elements/menu.py

+ 1 - 2
main.py

@@ -76,11 +76,10 @@ def add_header() -> None:
         with ui.link(target=index_page).classes('row gap-4 items-center no-wrap mr-auto'):
         with ui.link(target=index_page).classes('row gap-4 items-center no-wrap mr-auto'):
             svg.face().classes('w-8 stroke-white stroke-2')
             svg.face().classes('w-8 stroke-white stroke-2')
             svg.word().classes('w-24')
             svg.word().classes('w-24')
-        with ui.row().classes('lg:hidden'):
+        with ui.button(on_click=lambda: menu.open()).props('flat color=white icon=menu').classes('lg:hidden'):
             with ui.menu().classes('bg-primary text-white text-lg') as menu:
             with ui.menu().classes('bg-primary text-white text-lg') as menu:
                 for title, target in menu_items.items():
                 for title, target in menu_items.items():
                     ui.menu_item(title, on_click=lambda _, target=target: ui.open(target))
                     ui.menu_item(title, on_click=lambda _, target=target: ui.open(target))
-            ui.button(on_click=menu.open).props('flat color=white icon=menu')
         with ui.row().classes('max-lg:hidden'):
         with ui.row().classes('max-lg:hidden'):
             for title, target in menu_items.items():
             for title, target in menu_items.items():
                 ui.link(title, target).classes(replace='text-lg text-white')
                 ui.link(title, target).classes(replace='text-lg text-white')

+ 0 - 1
nicegui/elements/menu.py

@@ -17,7 +17,6 @@ class Menu(ValueElement):
         :param value: whether the menu is already opened (default: `False`)
         :param value: whether the menu is already opened (default: `False`)
         """
         """
         super().__init__(tag='q-menu', value=value, on_value_change=None)
         super().__init__(tag='q-menu', value=value, on_value_change=None)
-        self._props['no-parent-event'] = True
 
 
     def open(self) -> None:
     def open(self) -> None:
         self.value = True
         self.value = True