浏览代码

Merge pull request #2603 from Johannes-/fix/client-remove-elements

fix: order of remove elements
Falko Schindler 1 年之前
父节点
当前提交
939efba0c7
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      nicegui/client.py

+ 2 - 2
nicegui/client.py

@@ -294,12 +294,12 @@ class Client:
         """Remove the given elements from the client."""
         """Remove the given elements from the client."""
         binding.remove(elements)
         binding.remove(elements)
         element_ids = [element.id for element in elements]
         element_ids = [element.id for element in elements]
-        for element_id in element_ids:
-            del self.elements[element_id]
         for element in elements:
         for element in elements:
             element._handle_delete()  # pylint: disable=protected-access
             element._handle_delete()  # pylint: disable=protected-access
             element._deleted = True  # pylint: disable=protected-access
             element._deleted = True  # pylint: disable=protected-access
             self.outbox.enqueue_delete(element)
             self.outbox.enqueue_delete(element)
+        for element_id in element_ids:
+            del self.elements[element_id]
 
 
     def remove_all_elements(self) -> None:
     def remove_all_elements(self) -> None:
         """Remove all elements from the client."""
         """Remove all elements from the client."""