Browse Source

reduce number of page updates for custom components

Falko Schindler 3 years ago
parent
commit
9af624b0ab
2 changed files with 8 additions and 4 deletions
  1. 2 1
      nicegui/elements/custom_example.py
  2. 6 3
      nicegui/elements/joystick.py

+ 2 - 1
nicegui/elements/custom_example.py

@@ -15,7 +15,8 @@ class CustomExampleView(CustomView):
 
 
         self.options.value += msg.number
         self.options.value += msg.number
         if self.on_change is not None:
         if self.on_change is not None:
-            self.on_change(self.options.value)
+            return self.on_change(self.options.value)
+        return False
 
 
 class CustomExample(Element):
 class CustomExample(Element):
 
 

+ 6 - 3
nicegui/elements/joystick.py

@@ -22,17 +22,20 @@ class JoystickView(CustomView):
     def handle_start(self, msg):
     def handle_start(self, msg):
 
 
         if self.on_start is not None:
         if self.on_start is not None:
-            self.on_start(msg)
+            return self.on_start(msg)
+        return False
 
 
     def handle_move(self, msg):
     def handle_move(self, msg):
 
 
         if self.on_move is not None:
         if self.on_move is not None:
-            self.on_move(msg)
+            return self.on_move(msg)
+        return False
 
 
     def handle_end(self, msg):
     def handle_end(self, msg):
 
 
         if self.on_end is not None:
         if self.on_end is not None:
-            self.on_end(msg)
+            return self.on_end(msg)
+        return False
 
 
 class Joystick(Element):
 class Joystick(Element):