Browse Source

code review

Falko Schindler 1 year ago
parent
commit
d7b37fb631

+ 3 - 3
website/more_documentation/image_documentation.py

@@ -32,9 +32,9 @@ def more() -> None:
         src = 'https://assets1.lottiefiles.com/datafiles/HN7OcWNnoqje6iXIiZdWzKxvLIbfeCGTmvXmEm1h/data.json'
         ui.html(f'<lottie-player src="{src}" loop autoplay />').classes('w-full')
 
-    @text_demo('Image Link', '''
-        Images can link to another page by wrapping it in a [ui.link](https://nicegui.io/documentation/link).
+    @text_demo('Image link', '''
+        Images can link to another page by wrapping them in a [ui.link](https://nicegui.io/documentation/link).
     ''')
     def link():
-        with ui.link('', 'https://github.com/zauberzeug/nicegui', new_tab=True):
+        with ui.link(target='https://github.com/zauberzeug/nicegui'):
             ui.image('https://picsum.photos/id/41/640/360').classes('w-64')

+ 1 - 1
website/more_documentation/link_documentation.py

@@ -50,5 +50,5 @@ def more() -> None:
         [ui.image](/documentation/image), [ui.avatar](/documentation/image) etc.
     ''')
     def link_from_elements():
-        with ui.link('', 'https://github.com/zauberzeug/nicegui', new_tab=True):
+        with ui.link(target='https://github.com/zauberzeug/nicegui'):
             ui.image('https://picsum.photos/id/41/640/360').classes('w-64')