code review

nicegui/elements/chart.py

@@ -1,8 +1,8 @@
-import asyncio
 from typing import Dict
 
 import justpy as jp
 
+from .. import globals
 from ..task_logger import create_task
 from .element import Element
 
@@ -22,6 +22,6 @@ class Chart(Element):
         view.options = self.options = jp.Dict(**options)
         super().__init__(view)
 
-        if not jp.template_options['highcharts'] and asyncio.get_event_loop().is_running():
+        if not jp.template_options['highcharts'] and globals.loop and globals.loop.is_running():
             create_task(self.page.run_javascript('location.reload()'))
         jp.template_options['highcharts'] = True

nicegui/elements/element.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import asyncio
 from typing import Dict, Optional
 
 import justpy as jp

nicegui/elements/table.py

@@ -1,4 +1,3 @@
-import asyncio
 from typing import Dict
 
 import justpy as jp

nicegui/events.py

@@ -1,4 +1,3 @@
-import asyncio
 import traceback
 from dataclasses import dataclass
 from inspect import signature

nicegui/routes.py

@@ -1,4 +1,3 @@
-import asyncio
 import inspect
 import os.path
 from functools import wraps

nicegui/timer.py

@@ -61,8 +61,7 @@ class Timer:
                     await asyncio.sleep(self.interval)
 
         coroutine = timeout() if once else loop()
-        event_loop = asyncio.get_event_loop()
-        if not event_loop.is_running():
+        if not (globals.loop and globals.loop.is_running()):
             self.prepared_coroutines.append(NamedCoroutine(str(callback), coroutine))
         else:
             globals.tasks.append(create_task(coroutine, name=str(callback)))

nicegui/update.py

@@ -1,4 +1,3 @@
-import asyncio
 from typing import List
 
 from . import globals
@@ -7,7 +6,7 @@ from .task_logger import create_task
 
 
 def update(self, *elements: List[Element]) -> None:
-    if not (gobals.loop and globals.loop.is_running()):
+    if not (globals.loop and globals.loop.is_running()):
         return
     for element in elements:
         create_task(element.view.update())

tests/test_element.py

@@ -8,7 +8,7 @@ def test_classes(user: User):
     user.open('/')
 
     def assert_classes(classes: str) -> None:
-        for i in range(20):
+        for _ in range(20):
             if user.find('label').get_attribute('class') == classes:
                 return
             user.sleep(0.01)