refactor tests

tests/screen.py

@@ -113,6 +113,14 @@ class Screen:
             self.wait(0.1)
         raise AssertionError(f'Could not find input with value "{text}"')
 
+    def should_load_image(self, image: WebElement, *, timeout: float = 2.0) -> None:
+        deadline = time.time() + timeout
+        while time.time() < deadline:
+            js = 'return arguments[0].naturalWidth > 0 && arguments[0].naturalHeight > 0'
+            if self.selenium.execute_script(js, image):
+                return
+        raise AssertionError(f'Image not loaded: {image.get_attribute("outerHTML")}')
+
     def click(self, target_text: str) -> WebElement:
         element = self.find(target_text)
         try:

tests/test_image.py

@@ -1,11 +1,10 @@
-import time
 from pathlib import Path
 
 from nicegui import ui
 
 from .screen import Screen
 
-example_file = str(Path(__file__).resolve().parent / '../examples/slideshow/slides/slide1.jpg')
+example_file = Path(__file__).parent / '../examples/slideshow/slides/slide1.jpg'
 
 
 def test_base64_image(screen: Screen):
@@ -42,13 +41,7 @@ def test_setting_local_file(screen: Screen):
 
     screen.open('/')
     image = screen.find_by_class('q-img__image')
-    deadline = time.time() + 2
-    while time.time() < deadline:
-        js = 'return arguments[0].naturalWidth > 0 && arguments[0].naturalHeight > 0'
-        if screen.selenium.execute_script(js, image):
-            break
-    else:
-        assert False, 'image not loaded'
+    screen.should_load_image(image)
 
 
 def test_binding_local_file(screen: Screen):
@@ -57,13 +50,7 @@ def test_binding_local_file(screen: Screen):
 
     screen.open('/')
     image = screen.find_by_class('q-img__image')
-    deadline = time.time() + 2
-    while time.time() < deadline:
-        js = 'return arguments[0].naturalWidth > 0 && arguments[0].naturalHeight > 0'
-        if screen.selenium.execute_script(js, image):
-            break
-    else:
-        assert False, 'image not loaded'
+    screen.should_load_image(image)
 
 
 def test_set_source_with_local_file(screen: Screen):
@@ -71,11 +58,4 @@ def test_set_source_with_local_file(screen: Screen):
 
     screen.open('/')
     image = screen.find_by_class('q-img__image')
-    deadline = time.time() + 2
-    while time.time() < deadline:
-        js = 'return arguments[0].naturalWidth > 0 && arguments[0].naturalHeight > 0'
-        if screen.selenium.execute_script(js, image):
-            break
-    else:
-        assert False, 'image not loaded'
-    screen.wait(0.2)
+    screen.should_load_image(image)