Browse Source

code review

Falko Schindler 2 years ago
parent
commit
f5ec5402e8
2 changed files with 2 additions and 3 deletions
  1. 1 2
      nicegui/page.py
  2. 1 1
      tests/conftest.py

+ 1 - 2
nicegui/page.py

@@ -3,7 +3,6 @@ from __future__ import annotations
 import asyncio
 import asyncio
 import inspect
 import inspect
 import time
 import time
-import traceback
 import types
 import types
 import uuid
 import uuid
 from functools import wraps
 from functools import wraps
@@ -96,7 +95,7 @@ class Page(jp.QuasarPage):
                     elif isinstance(self.page_ready_generator, types.GeneratorType):
                     elif isinstance(self.page_ready_generator, types.GeneratorType):
                         self.page_ready_generator.send(PageEvent(msg.websocket))
                         self.page_ready_generator.send(PageEvent(msg.websocket))
             except (StopIteration, StopAsyncIteration):
             except (StopIteration, StopAsyncIteration):
-                pass  # after the page_ready_generator returns it will raise StopIteration; it's part oft the generator protocol and expected
+                pass  # after the page_ready_generator returns, it will raise StopIteration; it's part of the generator protocol and expected
             except:
             except:
                 globals.log.exception('Failed to execute page-ready')
                 globals.log.exception('Failed to execute page-ready')
             try:
             try:

+ 1 - 1
tests/conftest.py

@@ -62,5 +62,5 @@ def screen(selenium: webdriver.Chrome, request: pytest.FixtureRequest, caplog: p
     if screen.is_open:
     if screen.is_open:
         screen.shot(request.node.name)
         screen.shot(request.node.name)
     logs = screen.caplog.get_records('call')
     logs = screen.caplog.get_records('call')
-    assert len(logs) == 0, f'There were unexpected logs:\n-------\n{logs}\n-------'
+    assert not logs, f'There were unexpected logs:\n-------\n{logs}\n-------'
     screen.stop_server()
     screen.stop_server()