improve logic for icon name handling (#4988)

reflex/components/lucide/icon.py

@@ -53,42 +53,35 @@ class Icon(LucideIconComponent):
         if "tag" not in props:
             raise AttributeError("Missing 'tag' keyword-argument for Icon")
 
-        tag: str | Var | LiteralVar = Var.create(props.pop("tag"))
-        if isinstance(tag, LiteralVar):
-            if isinstance(tag, LiteralStringVar):
-                tag = tag._var_value
+        tag_var: Var | LiteralVar = Var.create(props.pop("tag"))
+        if isinstance(tag_var, LiteralVar):
+            if isinstance(tag_var, LiteralStringVar):
+                tag = format.to_snake_case(tag_var._var_value.lower())
             else:
-                raise TypeError(f"Icon name must be a string, got {type(tag)}")
-        elif isinstance(tag, Var):
-            tag_stringified = tag.guess_type()
+                raise TypeError(f"Icon name must be a string, got {type(tag_var)}")
+        elif isinstance(tag_var, Var):
+            tag_stringified = tag_var.guess_type()
             if not isinstance(tag_stringified, StringVar):
-                raise TypeError(f"Icon name must be a string, got {tag._var_type}")
+                raise TypeError(f"Icon name must be a string, got {tag_var._var_type}")
             return DynamicIcon.create(name=tag_stringified.replace("_", "-"), **props)
 
-        if (
-            not isinstance(tag, str)
-            or format.to_snake_case(tag) not in LUCIDE_ICON_LIST
-        ):
-            if isinstance(tag, str):
-                icons_sorted = sorted(
-                    LUCIDE_ICON_LIST,
-                    key=lambda s, tag=tag: format.length_of_largest_common_substring(
-                        tag, s
-                    ),
-                    reverse=True,
-                )
-            else:
-                icons_sorted = LUCIDE_ICON_LIST
+        if tag not in LUCIDE_ICON_LIST:
+            icons_sorted = sorted(
+                LUCIDE_ICON_LIST,
+                key=lambda s, tag=tag: format.length_of_largest_common_substring(
+                    tag, s
+                ),
+                reverse=True,
+            )
             console.warn(
                 f"Invalid icon tag: {tag}. Please use one of the following: {', '.join(icons_sorted[0:10])}, ..."
                 "\nSee full list at https://reflex.dev/docs/library/data-display/icon/#icons-list. Using 'circle-help' icon instead."
             )
-            tag = "circle-help"
+            tag = "circle_help"
 
-        if tag in LUCIDE_ICON_MAPPING_OVERRIDE:
-            props["tag"] = LUCIDE_ICON_MAPPING_OVERRIDE[tag]
-        else:
-            props["tag"] = format.to_title_case(format.to_snake_case(tag)) + "Icon"
+        props["tag"] = LUCIDE_ICON_MAPPING_OVERRIDE.get(
+            tag, format.to_title_case(tag) + "Icon"
+        )
         props["alias"] = f"Lucide{props['tag']}"
         props.setdefault("color", "var(--current-color)")
         return super().create(**props)