Bläddra i källkod

use is true for bool var (#3973)

Khaleel Al-Adhami 8 månader sedan
förälder
incheckning
73f3454b43
2 ändrade filer med 15 tillägg och 8 borttagningar
  1. 0 8
      reflex/vars/sequence.py
  2. 15 0
      tests/test_var.py

+ 0 - 8
reflex/vars/sequence.py

@@ -194,14 +194,6 @@ class StringVar(Var[str]):
         """
         return string_strip_operation(self)
 
-    def bool(self):
-        """Boolean conversion.
-
-        Returns:
-            The boolean value of the string.
-        """
-        return self.length() != 0
-
     def reversed(self) -> StringVar:
         """Reverse the string.
 

+ 15 - 0
tests/test_var.py

@@ -962,6 +962,21 @@ def test_all_number_operations():
     )
 
 
+@pytest.mark.parametrize(
+    ("var", "expected"),
+    [
+        (Var.create(False), "false"),
+        (Var.create(True), "true"),
+        (Var.create("false"), 'isTrue("false")'),
+        (Var.create([1, 2, 3]), "isTrue([1, 2, 3])"),
+        (Var.create({"a": 1, "b": 2}), 'isTrue(({ ["a"] : 1, ["b"] : 2 }))'),
+        (Var("mysterious_var"), "isTrue(mysterious_var)"),
+    ],
+)
+def test_boolify_operations(var, expected):
+    assert str(var.bool()) == expected
+
+
 def test_index_operation():
     array_var = LiteralArrayVar.create([1, 2, 3, 4, 5])
     assert str(array_var[0]) == "[1, 2, 3, 4, 5].at(0)"