Bläddra i källkod

FIX - Error: img is a self-closing tag and must neither have children nor use dangerouslySetInnerHTML. (#3307)

* fixed errors

* fix CI errors

* CI fix again

* used ruff formatting

* pyi fix

* fix app harness

---------

Co-authored-by: Elijah <elijahahianyo@gmail.com>
Yummy-Yums 1 år sedan
förälder
incheckning
efa9fcd6d5

+ 1 - 1
reflex/components/component.py

@@ -374,7 +374,7 @@ class Component(BaseComponent, ABC):
                 raise ValueError(
                 raise ValueError(
                     f"The {(comp_name := type(self).__name__)} does not take in an `{key}` event trigger. If {comp_name}"
                     f"The {(comp_name := type(self).__name__)} does not take in an `{key}` event trigger. If {comp_name}"
                     f" is a third party component make sure to add `{key}` to the component's event triggers. "
                     f" is a third party component make sure to add `{key}` to the component's event triggers. "
-                    f"visit https://reflex.dev/docs/wrapping-react/logic/#event-triggers for more info."
+                    f"visit https://reflex.dev/docs/wrapping-react/guide/#event-triggers for more info."
                 )
                 )
             if key in triggers:
             if key in triggers:
                 # Event triggers are bound to event chains.
                 # Event triggers are bound to event chains.

+ 19 - 0
reflex/components/el/elements/media.py

@@ -1,6 +1,7 @@
 """Element classes. This is an auto-generated file. Do not edit. See ../generate.py."""
 """Element classes. This is an auto-generated file. Do not edit. See ../generate.py."""
 from typing import Any, Union
 from typing import Any, Union
 
 
+from reflex import Component
 from reflex.vars import Var as Var
 from reflex.vars import Var as Var
 
 
 from .base import BaseHTML
 from .base import BaseHTML
@@ -116,6 +117,24 @@ class Img(BaseHTML):
     # The name of the map to use with the image
     # The name of the map to use with the image
     use_map: Var[Union[str, int, bool]]
     use_map: Var[Union[str, int, bool]]
 
 
+    @classmethod
+    def create(cls, *children, **props) -> Component:
+        """Override create method to apply source attribute to value if user fails to pass in attribute.
+
+        Args:
+            *children: The children of the component.
+            **props: The props of the component.
+
+        Returns:
+            The component.
+
+        """
+        return (
+            super().create(src=children[0], **props)
+            if children
+            else super().create(*children, **props)
+        )
+
 
 
 class Map(BaseHTML):
 class Map(BaseHTML):
     """Display the map element."""
     """Display the map element."""

+ 3 - 1
reflex/components/el/elements/media.pyi

@@ -8,6 +8,7 @@ from reflex.vars import Var, BaseVar, ComputedVar
 from reflex.event import EventChain, EventHandler, EventSpec
 from reflex.event import EventChain, EventHandler, EventSpec
 from reflex.style import Style
 from reflex.style import Style
 from typing import Any, Union
 from typing import Any, Union
+from reflex import Component
 from reflex.vars import Var as Var
 from reflex.vars import Var as Var
 from .base import BaseHTML
 from .base import BaseHTML
 
 
@@ -470,7 +471,7 @@ class Img(BaseHTML):
         ] = None,
         ] = None,
         **props
         **props
     ) -> "Img":
     ) -> "Img":
-        """Create the component.
+        """Override create method to apply source attribute to value if user fails to pass in attribute.
 
 
         Args:
         Args:
             *children: The children of the component.
             *children: The children of the component.
@@ -512,6 +513,7 @@ class Img(BaseHTML):
 
 
         Returns:
         Returns:
             The component.
             The component.
+
         """
         """
         ...
         ...