Browse Source

Do not callback on Cycle select (#1652)

resolves #1605

Co-authored-by: Fred Lefévère-Laoide <Fred.Lefevere-Laoide@Taipy.io>
Fred Lefévère-Laoide 9 months ago
parent
commit
4d0b87453a
1 changed files with 10 additions and 8 deletions
  1. 10 8
      frontend/taipy/src/CoreSelector.tsx

+ 10 - 8
frontend/taipy/src/CoreSelector.tsx

@@ -375,14 +375,16 @@ const CoreSelector = (props: CoreSelectorProps) => {
                 return;
                 return;
             }
             }
             setSelectedItems(() => {
             setSelectedItems(() => {
-                const lovVar = getUpdateVar(updateVars, lovPropertyName);
-                const val = multiple ? nodeId : isSelectable ? nodeId : "";
-                setTimeout(
-                    // to avoid set state while render react errors
-                    () => dispatch(createSendUpdateAction(updateVarName, val, module, onChange, propagate, lovVar)),
-                    1
-                );
-                onSelect && isSelectable && onSelect(val);
+                if (isSelectable) {
+                    const lovVar = getUpdateVar(updateVars, lovPropertyName);
+                    const val = nodeId;
+                    setTimeout(
+                        // to avoid set state while render react errors
+                        () => dispatch(createSendUpdateAction(updateVarName, val, module, onChange, propagate, lovVar)),
+                        1
+                    );
+                    onSelect && onSelect(val);
+                }
                 return Array.isArray(nodeId) ? nodeId : nodeId ? [nodeId] : [];
                 return Array.isArray(nodeId) ? nodeId : nodeId ? [nodeId] : [];
             });
             });
         },
         },