fix: raise instead of return NotImplementedError

taipy/core/data/_filter.py

@@ -135,7 +135,7 @@ class _FilterDataNode:
         elif join_operator == JoinOperator.OR:
             how = "outer"
         else:
-            return NotImplementedError
+            raise NotImplementedError
 
         filtered_df_data = [
             _FilterDataNode.__filter_dataframe_per_key_value(df_data, key, value, operator)
@@ -177,7 +177,7 @@ class _FilterDataNode:
         elif join_operator == JoinOperator.OR:
             join_conditions = reduce(or_, conditions)
         else:
-            return NotImplementedError
+            raise NotImplementedError
 
         return data[join_conditions]
 
@@ -199,7 +199,7 @@ class _FilterDataNode:
         if operator == Operator.GREATER_OR_EQUAL:
             return array_data[:, key] >= value
 
-        return NotImplementedError
+        raise NotImplementedError
 
     @staticmethod
     def __filter_list(list_data: List, operators: Union[List, Tuple], join_operator=JoinOperator.AND):
@@ -218,7 +218,7 @@ class _FilterDataNode:
                 return list({frozenset(item.items()) for item in merged_list})
             return list(set(merged_list))
         else:
-            return NotImplementedError
+            raise NotImplementedError
 
     @staticmethod
     def __filter_list_per_key_value(list_data: List, key: str, value, operator: Operator):

taipy/gui/data/utils.py

@@ -79,7 +79,7 @@ class Decimator(ABC):
                 from *data* should be preserved, or False requires that this
                 data point be dropped.
         """
-        return NotImplementedError  # type: ignore
+        raise NotImplementedError
 
 
 def _df_data_filter(

taipy/gui/extension/library.py

@@ -293,7 +293,7 @@ class ElementLibrary(ABC):
             because each JavaScript module will have to have a unique name.
 
         """
-        return NotImplementedError  # type: ignore
+        raise NotImplementedError
 
     def get_js_module_name(self) -> str:
         """

taipy/gui/utils/types.py

@@ -57,7 +57,7 @@ class _TaipyBase(ABC):
     @staticmethod
     @abstractmethod
     def get_hash():
-        return NotImplementedError
+        raise NotImplementedError
 
     @staticmethod
     def _get_holder_prefixes() -> t.List[str]:

tests/gui/utils/test_types.py

@@ -15,16 +15,16 @@ import warnings
 import pytest
 
 from taipy.gui.utils.date import _string_to_date
-from taipy.gui.utils.types import _TaipyBase, _TaipyBool, _TaipyDate, _TaipyNumber
+from taipy.gui.utils.types import _TaipyBool, _TaipyData, _TaipyDate, _TaipyNumber
 
 
-def test_taipy_base():
-    tb = _TaipyBase("value", "hash")
+def test_taipy_data():
+    tb = _TaipyData("value", "hash")
     assert tb.get() == "value"
     assert tb.get_name() == "hash"
     tb.set("a value")
     assert tb.get() == "a value"
-    assert tb.get_hash() == NotImplementedError
+    assert tb.get_hash() == "_TpD"
 
 
 def test_taipy_bool():