Преглед изворни кода

readable submission auth (#2357)

* readable submission auth
resolves #562

* unused import

---------

Co-authored-by: Fred Lefévère-Laoide <Fred.Lefevere-Laoide@Taipy.io>
Fred Lefévère-Laoide пре 5 месеци
родитељ
комит
996f52488c
2 измењених фајлова са 2 додато и 7 уклоњено
  1. 1 2
      taipy/gui_core/_context.py
  2. 1 5
      tests/gui_core/test_context_is_readable.py

+ 1 - 2
taipy/gui_core/_context.py

@@ -33,7 +33,6 @@ from taipy.core import (
     Sequence,
     SequenceId,
     Submission,
-    SubmissionId,
     cancel_job,
     create_scenario,
     delete_job,
@@ -155,7 +154,7 @@ class _GuiCoreContext(CoreEventConsumerBase):
         self.broadcast_core_changed({"scenario": scenario_id or True})
 
     def submission_status_callback(self, submission_id: t.Optional[str] = None, event: t.Optional[Event] = None):
-        if not submission_id or not is_readable(t.cast(SubmissionId, submission_id)):
+        if not submission_id:
             return
         submission = None
         new_status: t.Optional[SubmissionStatus] = None

+ 1 - 5
tests/gui_core/test_context_is_readable.py

@@ -213,10 +213,6 @@ class TestGuiCoreContext_is_readable:
             assert found is True
             mockget.reset_mock()
 
-            with patch("taipy.gui_core._context.is_readable", side_effect=mock_is_readable_false):
-                gui_core_context.submission_status_callback(a_submission.id)
-                mockget.assert_not_called()
-
     def test_data_node_adapter(self):
         with patch("taipy.gui_core._context.core_get", side_effect=mock_core_get):
             gui_core_context = _GuiCoreContext(Mock())
@@ -384,7 +380,7 @@ class TestGuiCoreContext_is_readable:
             mockget.reset_mock()
 
             with patch("taipy.gui_core._context.is_readable", side_effect=mock_is_readable_false):
-                gui_core_context.submission_status_callback(a_scenario.id)
+                gui_core_context.get_scenarios_for_owner(a_scenario.id)
                 mockget.assert_not_called()
 
     def test_update_data(self):